Skip to content

fix(grid): alter user colors for odd/even rows to avoid translucency #5985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 18, 2019
Merged

fix(grid): alter user colors for odd/even rows to avoid translucency #5985

merged 8 commits into from
Oct 18, 2019

Conversation

@simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Oct 15, 2019

Closes #5977

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff requested a review from desig9stein October 15, 2019 09:08
@zdrawku zdrawku assigned hanastasov and unassigned zdrawku Oct 15, 2019
@hanastasov hanastasov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 15, 2019
@hanastasov hanastasov added 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels Oct 15, 2019
@hanastasov
Copy link
Contributor

hanastasov commented Oct 15, 2019

Still reproducing on my side:
image

@hanastasov hanastasov added ✅ status: verified Applies to PRs that have passed manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 17, 2019
@hanastasov
Copy link
Contributor

hanastasov commented Oct 17, 2019

Still reproducing on my side:
image

Not reproducible anymore.

@kdinev kdinev merged commit 7917fb2 into 8.2.x Oct 18, 2019
@kdinev kdinev deleted the fix-#5977 branch October 18, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desig9stein desig9stein desig9stein approved these changes

Assignees

@hanastasov hanastasov

Labels

grid: general material-theme version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@simeonoff @hanastasov @desig9stein @kdinev @zdrawku @rkaraivanov @DiyanDimitrov